-
Notifications
You must be signed in to change notification settings - Fork 112
Typescript rewrite #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript rewrite #108
Conversation
Sorry for the extra commits I missed a few things on the first pass. Also I know a few places have |
@OmgImAlexis Thanks for the contribution. Can you raise PR against 8.0.0 branch? Also consider any documentation updates which might be needed. |
Can do. I'll make sure everything is sorted tomorrow and then I'll ping you to take another look. 🙏 |
@mithunsatheesh did you want to merge this PR and for me to open a new PR with the doc changes or keep adding commits here? |
@OmgImAlexis I meant let's merge the code in 8.0.0 release branch. Would need to look into integrations and readme files a bit to ensure its ready to merge in mainline. |
@mithunsatheesh @OmgImAlexis When are we expecting to be released. Looking for TS support for node-rules. Any eta. |
This rewrites the project to using typescript. Closes #75
All tests pass. Coverage is missing 3 lines
32, 45 and 133
.Breaking changes:
Since most people use bundlers nowadays it should be safe enough to drop webpack, etc. as the build tools from the project the person is using this on should be responsible for bundling not the library. In saying this I'd be okay with adding the webpack build back if it's really wanted.
NOTE: If you feel this is too big of a change feel free to close this.