Skip to content

Typescript rewrite #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 20, 2021
Merged

Typescript rewrite #108

merged 9 commits into from
Jul 20, 2021

Conversation

OmgImAlexis
Copy link

This rewrites the project to using typescript. Closes #75

All tests pass. Coverage is missing 3 lines 32, 45 and 133.

Breaking changes:

Since most people use bundlers nowadays it should be safe enough to drop webpack, etc. as the build tools from the project the person is using this on should be responsible for bundling not the library. In saying this I'd be okay with adding the webpack build back if it's really wanted.

NOTE: If you feel this is too big of a change feel free to close this.

@OmgImAlexis
Copy link
Author

Sorry for the extra commits I missed a few things on the first pass.

Also I know a few places have any or possibly incorrect types but this brings us a lot closer. I'll be happy to fix those issues as I have the time but I feel this should be merged first if possible.

@mithunsatheesh
Copy link
Owner

mithunsatheesh commented Jul 20, 2021

@OmgImAlexis Thanks for the contribution. Can you raise PR against 8.0.0 branch?
Once stable we can merge on mainline.

Also consider any documentation updates which might be needed.

@mithunsatheesh mithunsatheesh added this to the 8.0.0 milestone Jul 20, 2021
@OmgImAlexis
Copy link
Author

@OmgImAlexis Thanks for the contribution. Can you raise PR against 8.0.0 branch?

Once stable we can merge on mainline.

Also consider any documentation updates which might be needed.

Can do. I'll make sure everything is sorted tomorrow and then I'll ping you to take another look. 🙏

@OmgImAlexis OmgImAlexis changed the base branch from master to 8.0.0 July 20, 2021 10:13
@OmgImAlexis
Copy link
Author

@mithunsatheesh did you want to merge this PR and for me to open a new PR with the doc changes or keep adding commits here?

@mithunsatheesh
Copy link
Owner

@OmgImAlexis I meant let's merge the code in 8.0.0 release branch. Would need to look into integrations and readme files a bit to ensure its ready to merge in mainline.

@mithunsatheesh mithunsatheesh merged commit 2c5cc65 into mithunsatheesh:8.0.0 Jul 20, 2021
@nsingh2510
Copy link

@mithunsatheesh @OmgImAlexis When are we expecting to be released. Looking for TS support for node-rules. Any eta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript support
3 participants