-
Notifications
You must be signed in to change notification settings - Fork 112
8.0.0 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0.0 #109
Conversation
I think I may need to remove this line from the README. |
| You can see this in action in a node.js environment using this RunKit example. If you are interested to use it in the browser, use this JSFiddle for a quick start. @OmgImAlexis why? are they not functional now? |
The node example will work but it'll be up to the user to bundle it for the web. Maybe we could provide an ES module example since that'll work in all modern browsers without bundling? |
@OmgImAlexis I need to run bit of sanity on node and JS examples before merging to release branch. Areas we need to validate:
Would update you. |
|
@mithunsatheesh if you have a look at this you'll see the builds all succeed they just get stuck on the coveralls part since it doesn't have a token set. https://github.com/OmgImAlexis/node-rules/actions/runs/1047765610 |
@OmgImAlexis Previously we integrated with Travis. But Travis which is ceased from Jun 15th. I am exploring alternates for this. Thanks alot for the contribution around this. As I earlier said, let me spend some time in weekend and check if there is a way to have seemless migration of major versions 7 to 8 and get the CI in place. Should be done by end of this week. |
@mithunsatheesh as I mentioned the CI is in place already. I moved it over to GitHub Actions. You'll be able to see the results in the "Actions" tab in this repo once it's merged into master. If you'd like them to run now you just need to update https://github.com/mithunsatheesh/node-rules/blob/8.0.0/.github/workflows/main.yaml to allow it to run on |
To have seamless migration you'll want to update the package.json https://nodejs.org/api/packages.html#packages_package_entry_points Then make a file that does this and have it be the cjs export and use the const R = require('node-rules').RuleEngine;
module.exports = function RuleEngine(rules, options) {
return new R(rules, options);
}; |
The Then I'd add the {
"exports": {
"import": "./dist/node-rules.js",
"require": "./cjs-shim/node-rules.js"
}
} |
awesome! |
@mithunsatheesh what's the go on getting v8.0.0 released? |
@OmgImAlexis sorry about the delay. I have added you collaborator access to the repo which should allow you to make sufficient changes and release a new version. #113 was a bug we addressed which may not be present in the Typescript branch. Also please look at below recent change to node versions supported as well and carry it to the dev branch. Let me know if you need any help around it. |
@mithunsatheesh adding this to my schedule. Should have the new version released this week after confirming all existing bugs are squashed. |
thanks @OmgImAlexis |
This will be used for the last changes needed to make
8.0.0
ready for release.@mithunsatheesh anything I've missed?