Setting the read timeout in the RequestConfig is not enough. #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 11, 2018 11:31
The read timeout must be set in the SocketConfig as well. Setting the read timeout only in the RequestConfig can cause hangs which could block the whole proxy forever.
dsmiley
requested changes
Oct 14, 2018
createHttpClient() and do not create a customized socket configuration if no read timeout is set
|
Cool. Please update CHANGES.md too and I'll squash-merge. |
dsmiley
changed the title
|
@dsmiley done :) |
|
@dsmiley any release plans for 1.11? |
|
I think I will in a week or two. Feel free to harass me if I don't :-) |
|
@dsmiley PING :) |
|
@dsmiley PONG ? |
|
Tracked here: #157 |
|
This PR causes an incompatible change, our code no longer builds because of the overriding method has changed (we need to add HTTP basic auth). Therefore, release 1.11 really should have been called 2.0! |
|
I confess I don't pay much attention to backward compatibility; sorry. At least the proxy is small, and at least you got a build error instead of some silent semantics difference. |
|
David Smiley dixit:
I confess I don't pay much attention to backward compatibility; sorry.
OK. Maybe later? ☻
At least the proxy is small, and at least you got a build error instead
of some silent semantics difference.
Indeed. I’ve rolled back to the last version with the old method for now
and someone might eventually port it to the latest version. (It’s not my
code.) If interested:
https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=veraweb/veraweb.git;a=blob;f=core/src/main/java/de/tarent/veraweb/proxy/ProxyServlet.java;h=94934e06e5f9535e8e857a0467c3c3f422951c40;hb=refs/heads/master
bye,
//mirabilos
--
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read timeout must be set in the SocketConfig as well.
Setting the read timeout only in the RequestConfig can cause hangs which
could block the whole proxy forever.