Copy HttpOnly flag in proxy cookie #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 thanks! can you please also update CHANGES.md? I'll squash & merge |
|
Also be sure to mention the servlet-api 3.0 bump in CHANGES. |
|
@dsmiley will do it. are we going to bump the release version as well? |
|
updated change logs (maybe you want to update it further, coz I am not an English native speaker 🤦♂️ ) and bumped version to 1.12 |
|
1.11-SNAPSHOT is a Maven naming convention and means that 1.11 is in progress and hasn't been released. Once it's released, then the release process temporarily sets the version to 1.11 to publish and then we move onto 1.12-SNAPSHOT. So definitely do not bump the version number. Please move your change message to the 1.11 section. |
|
done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpOnly flag is missed when copying proxy cookies to request client.