Allow more flexible datatypes in measurements file #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Jul 29, 2025
| power_metric > 0, | ||
| unit, | ||
| '"' + weight_data_types + '"', | ||
| '"' + str(weight_data_types).replace("\"", "") + '"', |
Contributor
There was a problem hiding this comment.
Shall we replace " by '?
Contributor
Author
There was a problem hiding this comment.
Makes sense, will push that change
pgmpablo157321
force-pushed
the
checker_summary_fix
branch
from
5782ef3 to
da55aca
Compare
pgmpablo157321
force-pushed
the
checker_summary_fix
branch
from
da55aca to
05cb9a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2297