Improve SSE response handling and URI construction in SseClientSessio… #251
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#250 in order to solve this problem |
halter73
reviewed
Apr 9, 2025
src/ModelContextProtocol/Protocol/Transport/SseClientSessionTransport.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Normally, I'd ask for tests. But I'm working to support quickly support the 2025-03-26 Streamable HTTP spec right now, so I'll add some tests in a follow up.
https://modelcontextprotocol.io/specification/2025-03-26/basic/transports#streamable-http
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
SseClientSessionTransportclass to improve the handling of SSE messages and URI composition. The most important changes include enhancing the conditions for checking response content and refactoring the URI composition logic.Enhancements to response content checks:
responseContentis either empty or equals "accepted" in two locations within theSendMessageAsyncmethod. [1] [2]Refactoring URI composition:
HandleEndpointEventmethod to useUriBuilderfor more robust URI composition, including removing the manual string concatenation and handling the "/sse" suffix more effectively.