Separate ASP.NET Core tests into a distinct project and make the main test project netfx compatible. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test project netfx compatible.
eiriktsarpalis
force-pushed
the
separate-aspnet-tests
branch
from
cd7719e to
01ed88d
Compare
halter73
reviewed
Apr 9, 2025
There was a problem hiding this comment.
Error: /home/runner/work/csharp-sdk/csharp-sdk/tests/ModelContextProtocol.AspNetCore.Tests/SseIntegrationTests.cs(13,7): error CS0246: The type or namespace name 'TestServerWithHosting' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/csharp-sdk/csharp-sdk/tests/ModelContextProtocol.AspNetCore.Tests/ModelContextProtocol.AspNetCore.Tests.csproj::TargetFramework=net9.0]
Sorry about that. This got added right before you pushed this PR. Feel free to copy the EchoTool and SampleLlmTool into the ModelContextProtocol.AspNetCore.Tests project. I probably should have done that to begin with.
tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj
Outdated
Show resolved
Hide resolved
…proj Co-authored-by: Stephen Halter <[email protected]>
halter73
approved these changes
Apr 9, 2025
This reverts commit 852169b.
eiriktsarpalis
merged commit 39ab6cd
into
modelcontextprotocol:main
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.