Skip to content

Conversation

@topherbullock
Copy link
Contributor

Motivation and Context

the gem will be published to RubyGems under https://rubygems.org/gems/mcp as mcp, so gemspec, lib structure and naming should reflect this.

How Has This Been Tested?

moved files, renamed constants, ran tests; CI is green

Breaking Changes

none. ModelContextProtocol is aliased to MCP to allow backward compatibility if the gem has been leveraged using git instead of RubyGems by intrepid users.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

n/a

@topherbullock topherbullock requested a review from atesgoral May 26, 2025 16:32
@koic
Copy link
Member

koic commented May 26, 2025

I think that model_context_protocol (ModelContextProtocol module) might be a clearer name, rather than mcp (MCP module). The name appears to be effectively available:
https://rubygems.org/gems/model_context_protocol

In case publishing is not possible for some reason, contacting RubyGems would be advisable:
[email protected]

From a long-term perspective, a more descriptive name may be preferable to an abbreviation. A unique name, rather than an abbreviated one that might cause conflicts, is likely to be clearer for users.

@topherbullock
Copy link
Contributor Author

In case publishing is not possible for some reason, contacting RubyGems would be advisable: [email protected]

we've worked with RubyGems to claim https://rubygems.org/gems/mcp - MCP is established as an acronym in the sdks for other languages, so mcp as a gem name is preferred.

@koic
Copy link
Member

koic commented May 26, 2025

I see. I might have been too influenced by an LSP SDK gem:
https://rubygems.org/gems/language_server-protocol

Indeed, aligning with SDKs in other languages could be an option. Thank you for the explanation!

atesgoral
atesgoral previously approved these changes May 26, 2025
@atesgoral
Copy link
Contributor

Let's Fucking Go! LFG!

atesgoral
atesgoral previously approved these changes May 27, 2025
@topherbullock topherbullock requested a review from dsp-ant May 27, 2025 00:35
@topherbullock topherbullock merged commit 91219d3 into main May 29, 2025
11 checks passed
koic added a commit to koic/ruby-sdk that referenced this pull request May 30, 2025
Follow-up to modelcontextprotocol#24.

This PR fixes the following error when using `bin/console`:

```console
$ bin/console
/Users/koic/.rbenv/versions/3.4.4/lib/ruby/3.4.0/bundled_gems.rb:82:
in 'Kernel.require': cannot load such file -- model_context_protocol (LoadError)
from /Users/koic/.rbenv/versions/3.4.4/lib/ruby/3.4.0/bundled_gems.rb:82:
in 'block (2 levels) in Kernel#replace_require'
        from bin/console:5:in '<main>'
```
@koic koic mentioned this pull request May 30, 2025
9 tasks
@atesgoral atesgoral deleted the update-gemspec branch May 30, 2025 04:20
koic added a commit to koic/ruby-sdk that referenced this pull request May 31, 2025
Follow-up to modelcontextprotocol#24.

The directory structure of the product code and test code is expected to match.
koic added a commit to koic/ruby-sdk that referenced this pull request Jun 1, 2025
@koic koic mentioned this pull request Jun 1, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants