Memory - Fix: Update relation filter logic to use OR condition instead of AND #1442
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the relation filtering logic in the memory server's
searchNodes
andopenNodes
methods to correctly include relations connected to at least one filtered entity.Server Details
searchNodes
andopenNodes
toolsMotivation and Context
The current implementation filters relations using an
&&
condition, meaning a relation is only included if both its source and destination entities are present in the filtered entity list. This is incorrect behavior as it excludes relations that connect a filtered entity to an unfiltered one. The expected behavior is to include any relation where either the source or destination entity is in the filtered list.How Has This Been Tested?
openNodes
tool to verify correct relation inclusionBreaking Changes
None. This is a bug fix that maintains backward compatibility.
Types of changes
Checklist
Additional context
The change replaces the
&&
condition with an||
condition in bothsearchNodes
andopenNodes
methods: