Skip to content

Adjust logging level for frequent / low-level events #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Jun 5, 2025

Resolves #129

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Lower log level from debug to trace for frequent/low-level events across server, client, and transport layers.

  • Replace logger.debug calls with logger.trace for batch, request/response, notification, heartbeat, and SSE events.
  • No functional changes; purely adjusts verbosity.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Sources/MCP/Server/Server.swift Lowered batch, request, and notification logs from debug to trace
Sources/MCP/Client/Client.swift Changed response, notification, and batch response logs to trace
Sources/MCP/Base/Transports/StdioTransport.swift Updated message reception logs from debug to trace
Sources/MCP/Base/Transports/NetworkTransport.swift Adjusted heartbeat and connection logs from debug to trace
Sources/MCP/Base/Transports/HTTPClientTransport.swift Swapped debug to trace for SSE, JSON, and session ID signaling logs
Comments suppressed due to low confidence (1)

Sources/MCP/Base/Transports/HTTPClientTransport.swift:439

  • Indentation for this logger.trace call is inconsistent with the surrounding block; align it with the other logging statements (16 spaces).
logger.trace(

@mattt mattt force-pushed the mattt/trace-logging branch from 5bcac84 to 22ca0f6 Compare June 5, 2025 11:48
@mattt mattt merged commit 7a76001 into main Jun 5, 2025
6 checks passed
@mattt mattt deleted the mattt/trace-logging branch June 5, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[logger] use trace for low-level tracing info
1 participant