Fix phantom dependencies #575
Open
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhosmer-ant PTAL, thanks! |
|
I tested this and can confirm this PR fixes #572. Thank you @johnny-y-wang |
ihrpr
requested changes
Jun 12, 2025
| @@ -66,12 +66,14 @@ | |||
| "@types/cross-spawn": "^6.0.6", | |||
| "@types/eslint__js": "^8.42.3", | |||
| "@types/eventsource": "^1.1.15", | |||
| "@types/express": "^5.0.0", | |||
| "@types/express": "^5.0.2", | |||
There was a problem hiding this comment.
why do we need to update the version here?
There was a problem hiding this comment.
To align with express versioning and make TypeScript happy. (Granted that express needs to be bumped too, but I haven't done that.)
johnny-y-wang
commented
Jun 16, 2025
| @@ -66,12 +66,14 @@ | |||
| "@types/cross-spawn": "^6.0.6", | |||
| "@types/eslint__js": "^8.42.3", | |||
| "@types/eventsource": "^1.1.15", | |||
| "@types/express": "^5.0.0", | |||
| "@types/express": "^5.0.2", | |||
There was a problem hiding this comment.
To align with express versioning and make TypeScript happy. (Granted that express needs to be bumped too, but I haven't done that.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phantom dependencies into
package.jsonto enable pnpm (and other strict hoisting package manager) to build successfully. Fixes #572Motivation and Context
While this repo doesn't use pnpm or yarn, many of us import this into our monorepo and depend on strict dependency management. This enables
modelcontextprotocol/typescript-sdkto be included without monkeypatching.How Has This Been Tested?
Run
pnpm install && pnpm buildBreaking Changes
None
Types of changes
Checklist
Additional context