Skip to content

fix(compass-schema-validation): rules generated message COMPASS-9252 #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix(compass-schema-validation): rules generated message COMPASS-9252 #6843

merged 2 commits into from
Apr 11, 2025

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Apr 8, 2025 •
edited
Loading

Description

The 'rules are edited, please review before applying' message will be different right after the rules are generated. once the user makes changes, we go back to the 'rules are edited' message.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Apr 8, 2025
@paula-stacho paula-stacho added the no release notes Fix or feature not for release notes label Apr 8, 2025
@paula-stacho paula-stacho requested a review from Anemy April 8, 2025 14:27
Anemy
Anemy approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Once suggestion on adding more actions to be handled, not a blocker

@paula-stacho paula-stacho merged commit 2b2a627 into main Apr 11, 2025
78 of 79 checks passed
@paula-stacho paula-stacho deleted the COMPASS-9252 branch April 11, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paula-stacho @Anemy