feat: disable db and coll stats via preferences COMPASS-5387 #6852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Apr 11, 2025
paula-stacho
force-pushed
the
COMPASS-5387
branch
from
efcd98c to
a2461a5
Compare
gribnoysup
reviewed
Apr 14, 2025
packages/compass-settings/src/components/settings/settings-list.tsx
Outdated
Show resolved
Hide resolved
packages/compass-saved-aggregations-queries/src/stores/open-item.ts
Outdated
Show resolved
Hide resolved
paula-stacho
changed the title
Anemy
reviewed
Apr 21, 2025
gribnoysup
reviewed
Apr 22, 2025
| * @returns | ||
| */ | ||
| async fetch({ dataService, fetchInfo = true, force = false }) { | ||
| if (!shouldFetch(this.status, force)) { | ||
| return; | ||
| } | ||
|
|
||
| const instanceModel = getParentByType(this, 'Instance'); | ||
| const { enableDbAndCollStats } = instanceModel.preferences.getPreferences(); |
There was a problem hiding this comment.
Instead of exposing all the preferences directly from the instance model, can we limit the exposed interface to only what we need here? Something like:
Suggested change
| const { enableDbAndCollStats } = instanceModel.preferences.getPreferences(); | |
| const enableDbAndCollStats = instanceModel.shouldAllowStatsFetching(); |
As a rule of thumb I'd suggest to try to stay minimal when introducing these sort of cross boudary interfaces so that the intent of the exposed interface is clearer from just the name and the actual implementation can be changed easier
There was a problem hiding this comment.
that's a good idea, I'll do that!
There was a problem hiding this comment.
so I ended up using a property instead of a function, as I wanted to make sure we listen to updates on the preferences.
mcasimir
reviewed
Apr 22, 2025
mcasimir
reviewed
Apr 22, 2025
paula-stacho
force-pushed
the
COMPASS-5387
branch
2 times, most recently
from
9133126 to
cf4086f
Compare
paula-stacho
force-pushed
the
COMPASS-5387
branch
from
b1de544 to
856f210
Compare
Anemy
reviewed
Apr 28, 2025
Anemy
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/COMPASS-5387
Description
The stats are enabled by default and can be turned off in the configuration.
This affects views:
Menu
Databases list & grid
Collections list & grid
Collection -> Documents tab
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes