fix(compass): disable spellcheck before creating window when no network traffic COMPASS-8166 #6853
Conversation
| // to 2001:4860:4860::8888 (the IPv6 address for Google Public DNS). | ||
| (target) => | ||
| !/^127.0.0.1:|^\[::1\]:/.test(target) && | ||
| !/^\[2001:4860:4860::8888\]:443$/.test(target) |
There was a problem hiding this comment.
And I guess this is something we can't control at all?
There was a problem hiding this comment.
I haven't found one yet.
It seems like electron command line switches redirect it with the host rules / host resolver rules.
https://www.electronjs.org/docs/latest/api/command-line-switches#--host-rulesrules
I'll spend a bit of time looking into that and circle back before merging.
There was a problem hiding this comment.
Early on in our application code to override the host resolution it looks like we can:
app.commandLine.appendSwitch('host-resolver-rules', 'MAP 2001:4860:4860::8888 some_address');That will cause all of the network requests to start failing if it doesn't succeed though as I think more of the stack relies on this request for knowing where to send requests. I'm thinking as a fix we could maybe provide users a way to specify this themselves.
I'm going to merge this pr for the other fix and create a follow up ticket and link a todo in the code. I think it still needs a bit of investigation and thought
| // Passing a non-resolving URL prevents it from fetching | ||
| // as there aren't any options to disable it provided. | ||
| // https://github.com/electron/electron/issues/22995 | ||
| session.defaultSession.setSpellCheckerDictionaryDownloadURL( |
COMPASS-8166
We already were disabling the spellcheck when network traffic was disabled, however it looks like it was being disabled after the request for the dictionary would happen. This pr updates when we do the override to happen earlier.
The other change here is ignoring Google's public DNS ip in our no network test as its an expected functionality of chromium:
https://source.chromium.org/chromium/chromium/src/+/main:net/dns/README.md;l=351