Skip to content

chore(data-modeling): bootstrap data modeling workspace #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025

Conversation

gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Apr 16, 2025

This patch bootstraps a new workspace package in the monorepo and does some initial wiring so that the new workspace can be accessed through UI:

  • bootstrap new package with create-workspace script
  • add new feature flag
  • add new entrypoint in the sidebar
  • setup all required workspace types in the compass-workspace plugin
  • pass the plugin to the workspaces provider so that it can be rendered

I tried to structure commits in a way that should make it a bit easier to look through, most notably the first one has a decent amount of autogenerated code from the script, all the follow-up ones should be more straightforward

image

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Apr 16, 2025
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! One question on a default we might want to unset

@gribnoysup gribnoysup merged commit 2c9c609 into main Apr 16, 2025
58 of 59 checks passed
@gribnoysup gribnoysup deleted the bootstrap-data-modeling-plugin branch April 16, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants