Skip to content

feat: Add UI without functionality for "Start with an index" flow CLOUDP-311781 #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 23, 2025

Conversation

rubydong
Copy link
Collaborator

@rubydong rubydong commented Apr 18, 2025

Description

Set up the UI for "Start with an index flow". A lot of the functionality is not implemented yet and will be done in future tickets.
image

Screen.Recording.2025-04-21.at.1.44.37.PM.mov

still able to create index
image

Control
image

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@rubydong rubydong added the no release notes Fix or feature not for release notes label Apr 18, 2025
@github-actions github-actions bot added the feat label Apr 18, 2025
Comment on lines 87 to 88
if (!showIndexesGuidanceVariant) {
return (
Copy link
Collaborator Author

@rubydong rubydong Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some repetitive code for now but this would make it easier to clean up in the future whether we release the variant or keep things as is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating code will make it so that if we introduce unrelated changes, we'll have to remember to update both (and may lead to something not getting included). I think ideally we should avoid that. Are there large changes coming in the accordion changes that will make these very different?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for accordion we're just gonna change how it looks but nothing with functionality.
image
i thought it'd be cleaner this way but i can revert back to a combined view

@rubydong rubydong marked this pull request as ready for review April 21, 2025 20:48
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a couple comment, feel free to ping me on slack if you'd like to go over them sync!

Comment on lines 87 to 88
if (!showIndexesGuidanceVariant) {
return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating code will make it so that if we introduce unrelated changes, we'll have to remember to update both (and may lead to something not getting included). I think ideally we should avoid that. Are there large changes coming in the accordion changes that will make these very different?

@rubydong rubydong requested a review from Anemy April 22, 2025 19:10
@rubydong rubydong merged commit 8eec63f into main Apr 23, 2025
50 of 55 checks passed
@rubydong rubydong deleted the cloudp-311781 branch April 23, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants