-
Notifications
You must be signed in to change notification settings - Fork 214
feat: Add UI without functionality for "Start with an index" flow CLOUDP-311781 #6874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (!showIndexesGuidanceVariant) { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some repetitive code for now but this would make it easier to clean up in the future whether we release the variant or keep things as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating code will make it so that if we introduce unrelated changes, we'll have to remember to update both (and may lead to something not getting included). I think ideally we should avoid that. Are there large changes coming in the accordion changes that will make these very different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a couple comment, feel free to ping me on slack if you'd like to go over them sync!
packages/compass-indexes/src/components/create-index-form/index-flow-section.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-form/create-index-form.tsx
Outdated
Show resolved
Hide resolved
if (!showIndexesGuidanceVariant) { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating code will make it so that if we introduce unrelated changes, we'll have to remember to update both (and may lead to something not getting included). I think ideally we should avoid that. Are there large changes coming in the accordion changes that will make these very different?
Description
Set up the UI for "Start with an index flow". A lot of the functionality is not implemented yet and will be done in future tickets.

Screen.Recording.2025-04-21.at.1.44.37.PM.mov
still able to create index

Control

Checklist
Motivation and Context
Types of changes