feat(indexes): add Atlas search indexes link when banner dismissed COMPASS-9158 #6880
Conversation
| const DISMISSED_SEARCH_INDEXES_BANNER_LOCAL_STORAGE_KEY = | ||
| 'mongodb_compass_dismissedSearchIndexesBanner' as const; |
There was a problem hiding this comment.
This is duplicated in components/indexes/indexes.tsx - where I can put it in a common place?
syn-zhu
changed the title
Anemy
changed the title
There was a problem hiding this comment.
lgtm! one q on tests, not a blocker
Updated the pr/commit title to pass the check:
https://wiki.corp.mongodb.com/spaces/DRIVERS/pages/296292675/DevTools+PR+CR+Guidelines#DevToolsPR%2BCRGuidelines-PRTitleandDescription
Took me a bit to find where those docs are now lol, in the morning I'll check that the github action links to that.
| @@ -42,6 +42,8 @@ describe('IndexesToolbar Component', function () { | |||
| onIndexViewChanged={() => {}} | |||
| onCreateRegularIndexClick={() => {}} | |||
| onCreateSearchIndexClick={() => {}} | |||
| namespace="" | |||
| showAtlasSearchLink={false} | |||
There was a problem hiding this comment.
Should we add a unit test to make sure it's the right url?
There was a problem hiding this comment.
I think that's already somewhat covered by https://github.com/mongodb-js/compass/blob/main/packages/compass-indexes/src/utils/atlas-search-indexes-link.spec.ts?
https://jira.mongodb.org/browse/COMPASS-9158
Screen.Recording.2025-04-28.at.8.11.44.PM.mov
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes