feat(data-modeling): display errors when creating a diagram COMPASS-9307 #6892
Conversation
mabaasit
added
the
feature flagged
| @@ -287,15 +295,25 @@ export const generateDiagramWizardReducer: Reducer< | |||
| if (isAction(action, GenerateDiagramWizardActionTypes.CONNECTION_FAILED)) { | |||
| return { | |||
| ...state, | |||
| inProgress: false, | |||
| error: action.error, | |||
| step: 'SELECT_CONNECTION', | |||
There was a problem hiding this comment.
We actually do want to close the wizard when connecting fails. This lets the user click the Review button on the connect error toast. It's something we have in the scope: https://docs.google.com/document/d/1DX1F7LWirV1WkVV3G4RNEyxoX64oRPBYsJbd2NgL8OY
Sorry for not having this explicitly on the ticket, that's a miss on my end.
We don't need to show any connection error here then, the toast handles that.
There was a problem hiding this comment.
In that case i wonder if we should start with name? We let user enter the name and then its kinda lost if we close the modal when connection fails. But as its explicit in scope, i'll revert this behaviour.
There was a problem hiding this comment.
I agree it's weird behavior, normally the user should be able to continue the flow.. could we offer them the review button from here? then the connection modal would open on top of it. but only if it's straightforward - it's not worth much effort for the name only (especially since it might end up being autogenerated)
There was a problem hiding this comment.
I'm thinking that would make more sense, but then that review button opens up a different modal. Maybe connect being first makes sense. We can follow up, good things raised.
In this PR, we are showing errors to the user that are caused listing databases/collections.
Preview
For listing databases/collections, the error is not thrown COMPASS-5275. In the screenshot, i manually threw an error to mimic how it looks.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes