feat(data-modeling): add collection search and fix styles COMPASS-9308 COMPASS-9309 #6895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unexpectedly, making changes with active search can mean loosing the previous selection (only the search results are kept in that instance). See video: Screen.Recording.2025-05-06.at.14.06.25.mov |
Nice catch. Fixed in d308e26 |
mabaasit
changed the title
mabaasit
added
the
feature flagged
…PASS-9308-dm-loading-states
Anemy
approved these changes
May 6, 2025
| footerText: ( | ||
| <> | ||
| <strong>{selectedCollections.length}</strong>/ | ||
| <strong>{collections.length}</strong> total collections selected. |
There was a problem hiding this comment.
nit, the s here could be not plural if there is only 1 collection possible (same with the description)
Anemy
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added spinner when we are in loading state and search for collections.
Preview
Screen.Recording.2025-05-06.at.12.08.11.mov
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes