feat: Made early indexes variables update when changed CLOUDP-317478 #6901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubydong
changed the title
Anemy
reviewed
May 7, 2025
Comment on lines
16
to
18
|
|
||
| // Value can change from false to true during allocation / checking | ||
| 'enableIndexesGuidanceExp', |
There was a problem hiding this comment.
Can we move these to under cloudFeatureRolloutAccess? That ones also can be false -> true.
There was a problem hiding this comment.
Also in the comment, can we add TODO(COMPASS-9353): Provide a standard for updating Compass preferences in web? That way it's mentioned in the code.
There was a problem hiding this comment.
updated but not sure if new comment placement is what you were thinking of
Comment on lines
+298
to
+299
| const updateEarlyIndexesPreferences = async () => { | ||
| await preferencesAccess.current.savePreferences({ |
There was a problem hiding this comment.
Nice, can we add a comment linking this jira ticket so future readers have a bit more context?
Suggested change
| const updateEarlyIndexesPreferences = async () => { | |
| await preferencesAccess.current.savePreferences({ | |
| // TODO(COMPASS-9353): Provide a standard way of updating Compass' preferences from web. | |
| // Avoid duplicating this pattern until we address this ticket. | |
| const updateEarlyIndexesPreferences = async () => { | |
| await preferencesAccess.current.savePreferences({ |
Anemy
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.mongodb.org/browse/CLOUDP-317478
in variant
in control
tested in cloud-dev with redwood running on local
Checklist
Motivation and Context
Types of changes