Skip to content

feat: Added new accordion with updated styles CLOUDP-314036 #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

feat: Added new accordion with updated styles CLOUDP-314036 #6902

merged 3 commits into from
May 9, 2025

Conversation

rubydong
Copy link
Collaborator

@rubydong rubydong commented May 7, 2025 •
edited
Loading

Description

https://jira.mongodb.org/browse/CLOUDP-314036
Update accordion copy if user is in the variant to 'Index Options'

variant:
image
control:
image

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label May 7, 2025
@rubydong rubydong added the no release notes Fix or feature not for release notes label May 7, 2025
@rubydong rubydong marked this pull request as ready for review May 7, 2025 16:33
@Anemy Anemy added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label May 7, 2025
Anemy
Anemy reviewed May 7, 2025
View reviewed changes
packages/compass-indexes/src/components/create-index-form/create-index-form.tsx Outdated
</div>
</CreateIndexOptionsAccordion>
) : (
<Accordion
Copy link
Member

@Anemy Anemy May 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use the existing accordion here? It would be nice to keep things standard in Compass where we can. If it's design changes here, maybe we should update the existing accordion?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question here https://mongodb.slack.com/archives/C06SXC3BUUQ/p1746637912608249

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all these changes and we ended up only having to change the copy

@rubydong rubydong requested a review from Anemy May 9, 2025 15:02
@rubydong rubydong added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 9, 2025
@rubydong rubydong merged commit 09f1758 into main May 9, 2025
55 of 61 checks passed
@rubydong rubydong deleted the cloudp-314036 branch May 9, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
feat feature flagged PRs labeled with this label will not be included in the release notes of the next release no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubydong @Anemy