feat: Open create index modal with query context CLOUDP-311788 #6904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
approved these changes
May 7, 2025
Anemy
approved these changes
May 7, 2025
|
Looking good so far!! i think you have some typing issues though and can you also add "We prefilled the query input below based on your recently run query" if it's opened from the nudge 
|
rubydong
reviewed
May 8, 2025
Comment on lines
86
to
90
| // const enableInIndexesGuidanceExp = usePreference('enableIndexesGuidanceExp'); | ||
| // const showIndexesGuidanceVariant = | ||
| // usePreference('showIndexesGuidanceVariant') && enableInIndexesGuidanceExp; | ||
| const enableInIndexesGuidanceExp = true; | ||
| const showIndexesGuidanceVariant = true; |
There was a problem hiding this comment.
oh woops 😓 sloppy commits. removed though!
rubydong
changed the title
rubydong
approved these changes
May 8, 2025
rubydong
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOUDP-311788
Description
queryfield to Create Index redux store and redux actionsopen-create-index-modalevents withquerycontextquerycontext from store to componentsScreen.Recording.2025-05-07.at.1.51.49.PM.mov
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes