chore(webpack, web): add saslprep no-op alias for webpack bundle web #6911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
added
the
no-title-validation
nbbeeken
approved these changes
May 9, 2025
| // no-op | ||
| } | ||
|
|
||
| export default { |
There was a problem hiding this comment.
the named export above is the only one the driver uses.
But I understand wanting to cover your bases by making the "compatible" with the actual saslprep. If we want that then we'd need the export = as well.
No strong feelings though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're hitting the 10mb limit for the bundle:
compass/packages/compass-web/webpack.config.js
Lines 18 to 23 in 5421da4
These changes bring the size back down a bit.
npm run analyzein thecompass-webpackage for webpack analysis.Related slack thread https://mongodb.slack.com/archives/G2L10JAV7/p1746808113154329