fix: tweak native-machine-id scripts #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
May 6, 2025
| @@ -9,11 +9,13 @@ | |||
| "bootstrap": "npm run compile", | |||
| "pretest": "npm run compile", | |||
| "install": "node-gyp rebuild", | |||
| "typecheck": "tsc --noEmit", | |||
| "test": "mocha", | |||
| "test-cov": "nyc -x \"**/*.spec.*\" --reporter=lcov --reporter=text --reporter=html npm run test", | |||
| "test-ci": "npm run test-cov", | |||
| "lint": "eslint . && prettier --check .", | |||
There was a problem hiding this comment.
We'll also want to add prettier as a dev dependency and add a reformat script, I think
gagik
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
checkscript was running test, which is inconsistent with the other packages - I've changed it to be consistent with the rest of the packages where it runs typecheck and depcheck, but not test.