chore: improve descriptions about connection - MCP-224 #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
commented
Sep 25, 2025
| * @param additionalProperties - Additional properties specific to the event | ||
| */ | ||
| private emitServerEvent(command: ServerCommand, commandDuration: number, error?: Error): void { | ||
| private emitServerTelemetryEvent(command: ServerCommand, commandDuration: number, error?: Error): void { |
There was a problem hiding this comment.
flyby: emitServerEvent feels misleading, so I renamed it
There was a problem hiding this comment.
Pull Request Overview
This PR enhances tool descriptions and server configuration information to provide better guidance for MCP clients that may not handle update events properly. The changes focus on making connection status and server capabilities more transparent.
Key changes:
- Enhanced tool descriptions to clarify connection state and when to use the connect tool
- Added server instructions capability with dynamic configuration details
- Improved logging and telemetry for better observability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/integration/tools/mongodb/connect/connect.test.ts |
Updates test to validate the enhanced connect tool description |
src/tools/mongodb/connect/connect.ts |
Adds detailed description and logging for connect tool metadata updates |
src/server.ts |
Adds instructions capability, improves validation, and enhances resource update logging |
src/common/logger.ts |
Adds new log ID for tool metadata updates |
kmruiz
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Going off of the assumption that some MCP clients are not able to handle update events properly, this PR adds a bit more information about the server functioning with its configuration and some fly-by fixes.
Checklist