VS-156: Support Strong Named 2.28 Driver #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jul 25, 2024
tests/MongoDB.Analyzer.Tests/Infrastructure/DiagnosticsAnalyzer.cs
Outdated
Show resolved
Hide resolved
tests/MongoDB.Analyzer.Tests/Infrastructure/DiagnosticsAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/MongoDB.Analyzer/Core/Utilities/AnalysisCodeGeneratorUtilities.cs
Outdated
Show resolved
Hide resolved
BorisDog
requested changes
Jul 26, 2024
src/MongoDB.Analyzer/Core/Utilities/AnalysisCodeGeneratorUtilities.cs
Outdated
Show resolved
Hide resolved
src/MongoDB.Analyzer/Core/Utilities/AnalysisCodeGeneratorUtilities.cs
Outdated
Show resolved
Hide resolved
src/MongoDB.Analyzer/Core/Utilities/AnalysisCodeGeneratorUtilities.cs
Outdated
Show resolved
Hide resolved
BorisDog
requested changes
Jul 26, 2024
| @@ -56,5 +60,7 @@ analysisType switch | |||
| AnalysisType.Poco => JsonSyntaxElements.Poco.JsonGeneratorFullName, | |||
| _ => throw new ArgumentOutOfRangeException(nameof(analysisType), analysisType, "Unsupported analysis type") | |||
| }; | |||
|
|
|||
| private static bool IsDriverVersion_2_28_Or_Greater(Version driverVersion) => driverVersion >= s_driverVersion_2_28; | |||
There was a problem hiding this comment.
It's pretty simple condition, probably no need for a separate method.
| PathUtilities.VerifyTestDataModelAssembly(); | ||
| var isDriverVersion_2_28_OrGreater = PathUtilities.IsDriverVersion_2_28_OrGreater(driverVersion); | ||
| var testDataModelAssembly = isDriverVersion_2_28_OrGreater ? PathUtilities.TestDataModelAssemblyPathDriver_2_28_OrGreater : PathUtilities.TestDataModelAssemblyPathDriver_2_27_OrLower; | ||
| PathUtilities.VerifyTestDataModelAssembly(testDataModelAssembly); |
There was a problem hiding this comment.
Maybe refactor all this to PathUtililites.GetTestDataModelAssemblyPath?
BorisDog
approved these changes
Jul 26, 2024
| syntaxTrees, | ||
| referencesContainer.References, | ||
| new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary)); | ||
| new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary, publicSign: true, cryptoPublicKey: s_publicKey.ToImmutableArray())); |
There was a problem hiding this comment.
make s_publicKey immutable array, to skip the conversion each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.