CSHARP-3494: Fix discriminator for generic types #1685
Conversation
|
This is still a draft as we need to discuss if this is the kind of solution we want. |
|
|
||
| namespace MongoDB.Driver.Tests.Jira | ||
| { | ||
| public class CSharp3494Tests : Linq3IntegrationTest |
There was a problem hiding this comment.
We can decide to move these tests somewhere else if it makes more sense. Also this test does not need to derive from Linq3IntegrationTest.
There was a problem hiding this comment.
If these tests don't use the driver they should live in the MongoDB.Bson.Tests project instead of here.
But you may want to make integration tests also, where we write a document to the database and prove that we can read it back.
| @@ -1057,7 +1057,7 @@ public void Reset() | |||
| _creatorMaps.Clear(); | |||
| _creator = null; | |||
| _declaredMemberMaps = new List<BsonMemberMap>(); | |||
| _discriminator = _classType.Name; | |||
| _discriminator = BsonUtils.GetFriendlyTypeName(_classType); | |||
There was a problem hiding this comment.
This might fix it for BsonClassMap based serializers.
But shouldn't this be fixed more generally somehow?
|
|
||
| namespace MongoDB.Driver.Tests.Jira | ||
| { | ||
| public class CSharp3494Tests : Linq3IntegrationTest |
There was a problem hiding this comment.
If these tests don't use the driver they should live in the MongoDB.Bson.Tests project instead of here.
But you may want to make integration tests also, where we write a document to the database and prove that we can read it back.
| { | ||
| public class CSharp3494Tests : Linq3IntegrationTest | ||
| { | ||
| abstract class BaseDocument; |
There was a problem hiding this comment.
Normally we put all the classes after the test methods.
In this file they are mixed in an unusual order, switching back and forth between test methods and class declarations.
| rehydrated.Should().BeOfType<DerivedDocument2<int>>(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We should test generic types with more than one type parameter like Dictionary<string, int>.
And see if you can come up with a test with nested generic types, maybe something like IEnumerable<KeyValuePair<string, int>>.
| public void Correct_discriminator_should_be_used_for_generic_type() | ||
| { | ||
| var document = new DerivedDocument<int> { Id = 1, Value = 42 }; | ||
| var serialized = document.ToJson(typeof(BaseDocument)); |
There was a problem hiding this comment.
Consider using the parameter name to make it clear that we're calling ToJson with a nominal type:
var serialized = document.ToJson(nominalType: typeof(BaseDocument));
| { | ||
| var document = new DerivedDocument<int> { Id = 1, Value = 42 }; | ||
| var serialized = document.ToJson(typeof(BaseDocument)); | ||
| serialized.Should().Be("""{ "_t" : "DerivedDocument<Int32>", "_id" : 1, "Value" : 42 }"""); |
There was a problem hiding this comment.
I thought the _id was always supposed to be first.
But maybe we only do that during serialization (and only in BsonClassMapSerializer).
No description provided.