CSHARP-3384: Define error handling behavior of writeErrors and writeConcernError on Mongos #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oncernError on Mongos
jyemin
requested review from
JamesKovacs and
DmitryLukyanov
and removed request for
jyemin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.mongodb.org/browse/CSHARP-3384
EG: https://evergreen.mongodb.com/version/6063856b3e8e861ac9faf89c
Specification: mongodb/specifications@849adad
Note: I reused the same test runner change from #483 PR, which assumes that
ExceptionMapper.MapNotPrimaryOrNodeIsRecoveringis able to return no exception.