-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-3745 Add support for multiphase initialization #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I scheduled all of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set https://docs.python.org/3/c-api/module.html#c.Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTED on 3.12+? IIUC that's what we support. The new work would be to set Py_MOD_PER_INTERPRETER_GIL_SUPPORTED.
Without Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTED I think this change could break some users.
Fixed |
mod_wsgi 4.x Python 3.7 Ubuntu 22.04 is failing intermittently, both with and without the Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTED block. |
Is it also failing on main or only after the multiphase changes? |
After the multiphase changes |
I suggest we open a mod_wsgi issue to ask if multiphase init modules are supported: https://github.com/GrahamDumpleton/mod_wsgi |
It's the interpreter itself that defines compat as I understand it, the feature should be usable from Python 3.5. I propose we close this PR and restart when we can test directly against subinterpreters to see if there is an actual bug. |
I think it could be a bug in mod_wsgi because it has custom code to create subinterpreters. We'll also still need to keep the mod_wsgi tests even once we can test subinterpreters directly so I think we should try investigating the mod_wsgi bug now to avoid delaying this change. |
I'm going to have to backlog this for now until I finish OIDC work. |
Closing in favor of #1499 |
No description provided.