PYTHON-2723 Convert transactions spec tests to unified test format #1543

blink1073 · 2024-03-06T21:18:25Z

No description provided.

…PYTHON-2723

ShaneHarvey

The tests are taking a long time because many are waiting 60 seconds for open transactions to time out. We need to add killAllSessions as described here: https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#terminating-open-transactions

Note we already do this in the legacy txn test runner here:

mongo-python-driver/test/utils_spec_runner.py

Lines 177 to 185 in 992d150

    
           def kill_all_sessions(self): 
        
               clients = self.mongos_clients if self.mongos_clients else [self.client] 
        
               for client in clients: 
        
                   try: 
        
                       client.admin.command("killAllSessions", []) 
        
                   except OperationFailure: 
        
                       # "operation was interrupted" by killing the command's 
        
                       # own session. 
        
                       pass

…PYTHON-2723

…th propagating exceptions from a callback operation to withTransaction

blink1073 · 2024-03-26T01:56:17Z

evergreen retry

blink1073 · 2024-03-26T09:19:56Z

evergreen retry

blink1073 · 2024-03-26T13:41:21Z

Evergreen is failing to create the patch build because the diff is too big, here is a manual patch: https://spruce.mongodb.com/version/66022b707612660007a780f0/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

blink1073 · 2024-03-26T13:42:00Z

I verified that the transaction tests are run on serverless.

ShaneHarvey · 2024-03-26T18:26:53Z

test/unified_format.py

@@ -1229,6 +1235,16 @@ def _databaseOperation_createCommandCursor(self, target, **kwargs):

        return cursor

+    def kill_all_sessions(self):
+        if getattr(self, "client", None) is None:


Why would client be None here? Should we be using the client_context.client?

It was None on two of the tests that were testing the spec runner itself without creating a client.

Oh I see it's TestCreateEntities.

ShaneHarvey · 2024-03-26T18:27:29Z

test/unified_format.py

+        if getattr(self, "client", None) is None:
+            return
+        try:
+            self.client.admin.command("killAllSessions", [])


In the legacy runner, we would run this on all mongoses. I think we should do that here too.

I couldn't find the equivalent of mongos_clients, it looks like all clients go through this line:

mongo-python-driver/test/unified_format.py

Line 501 in f757fe3

self[spec["id"]] = client

We'll need to create those clients like is done in the legacy txn tests:

mongo-python-driver/test/test_transactions.py

Line 71 in 992d150

cls.mongos_clients.append(single_client("{}:{}".format(*address)))

ShaneHarvey · 2024-03-26T18:29:05Z

test/unified_format.py

+            else:
+                result = self.run_entity_operation(op)
+                if isinstance(result, Exception):
+                    raise result


Why re-raise this exception after ignoreResultAndError or expectError? Does the spec say to do that somewhere?

Yes, "Ensure that neither ignoreResultAndError nor expectError interfere with propagating exceptions from a callback operation to withTransaction"

Where is that written? That line doesn't appear in the spec repo.

That is from the ticket description, there is more discussion on the original spec PR.

blink1073 · 2024-03-26T20:03:36Z

New manual patch: https://spruce.mongodb.com/version/660329f0ca19fe0007f917c6/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

ShaneHarvey · 2024-03-26T21:05:22Z

What's up with the "@evergreen-ci-prod evergreen — Evergreen error" in the check?

ShaneHarvey · 2024-03-26T21:07:41Z

 [2024/03/26 13:15:00.064] ERROR: failed on setup with "pymongo.errors.ConfigurationError: Cannot specify directConnection=true with loadBalanced=true" ()
 [2024/03/26 13:15:00.064] cls = <class 'test.test_auth_spec.TestUnifiedReauthenticateWithRetry'>
 [2024/03/26 13:15:00.064]     @classmethod
 [2024/03/26 13:15:00.064]     def setUpClass(cls):
 [2024/03/26 13:15:00.064]         # super call creates internal client cls.client
 [2024/03/26 13:15:00.064]         super().setUpClass()
 [2024/03/26 13:15:00.064]         # process file-level runOnRequirements
 [2024/03/26 13:15:00.064]         run_on_spec = cls.TEST_SPEC.get("runOnRequirements", [])
 [2024/03/26 13:15:00.064]         if not cls.should_run_on(run_on_spec):
 [2024/03/26 13:15:00.064]             raise unittest.SkipTest(f"{cls.__name__} runOnRequirements not satisfied")
 [2024/03/26 13:15:00.064]     
 [2024/03/26 13:15:00.064]         # Handle mongos_clients for transactions tests.
 [2024/03/26 13:15:00.064]         cls.mongos_clients = []
 [2024/03/26 13:15:00.064]         if client_context.supports_transactions():
 [2024/03/26 13:15:00.064]             for address in client_context.mongoses:
 [2024/03/26 13:15:00.064] >               cls.mongos_clients.append(single_client("{}:{}".format(*address)))
 [2024/03/26 13:15:00.064] test/unified_format.py:1022: 
 [2024/03/26 13:15:00.064] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 [2024/03/26 13:15:00.064] test/utils.py:604: in single_client
 [2024/03/26 13:15:00.064]     return _mongo_client(h, p, directConnection=True, **kwargs)
 [2024/03/26 13:15:00.064] test/utils.py:594: in _mongo_client
 [2024/03/26 13:15:00.064]     return MongoClient(uri, port, **client_options)
 [2024/03/26 13:15:00.064] pymongo/mongo_client.py:825: in __init__
 [2024/03/26 13:15:00.064]     _check_options(seeds, opts)
 [2024/03/26 13:15:00.064] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 [2024/03/26 13:15:00.064] nodes = {('32071-drivertest-lb.3x79d.mongodb-dev.net', 27017)}
 [2024/03/26 13:15:00.064] options = {'loadBalanced': True, 'compressors': ['zlib'], 'tls': True, 'directConnection': True, 'username': 'drivers-testing', 'password': '47l0tpPl13dobvHF', 'document_class': <class 'dict'>, 'tz_aware': False, 'connect': True}
 [2024/03/26 13:15:00.064]     def _check_options(nodes: Sized, options: Mapping[str, Any]) -> None:
 [2024/03/26 13:15:00.064]         # Ensure directConnection was not True if there are multiple seeds.
 [2024/03/26 13:15:00.064]         if len(nodes) > 1 and options.get("directconnection"):
 [2024/03/26 13:15:00.064]             raise ConfigurationError("Cannot specify multiple hosts with directConnection=true")
 [2024/03/26 13:15:00.064]     
 [2024/03/26 13:15:00.064]         if options.get("loadbalanced"):
 [2024/03/26 13:15:00.064]             if len(nodes) > 1:
 [2024/03/26 13:15:00.064]                 raise ConfigurationError("Cannot specify multiple hosts with loadBalanced=true")
 [2024/03/26 13:15:00.064]             if options.get("directconnection"):
 [2024/03/26 13:15:00.064] >               raise ConfigurationError("Cannot specify directConnection=true with loadBalanced=true")
 [2024/03/26 13:15:00.064] E               pymongo.errors.ConfigurationError: Cannot specify directConnection=true with loadBalanced=true
 [2024/03/26 13:15:00.064] pymongo/uri_parser.py:403: ConfigurationError

Looks like the mongos_clients logic needs to be skipped on serverless+loadBalanced clusters.

blink1073 · 2024-03-26T21:16:22Z

What's up with the "@evergreen-ci-prod evergreen — Evergreen error" in the check?

The diff is too big, they're working on a fix where it will at least submit the patch even if the diff part fails.

blink1073 · 2024-03-26T21:19:18Z

Looks like the mongos_clients logic needs to be skipped on serverless+loadBalanced clusters.

Done

https://spruce.mongodb.com/version/66033b7a8b69b6000726fb32/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

ShaneHarvey

LGTM

blink1073 added 4 commits March 6, 2024 15:18

PYTHON-2723 Convert transactions spec tests to unified test format

72d635e

convert to unified tests

4661ce8

Merge branch 'master' of github.com:mongodb/mongo-python-driver into …

2a8f24c

…PYTHON-2723

fix handling of write concern

c9f44d4

ShaneHarvey requested changes Mar 21, 2024

View reviewed changes

blink1073 added 5 commits March 22, 2024 06:10

add kill_sessions

7670959

guard against not client property

c1aab8d

fix handling of upsertedId

94eb1c3

Merge branch 'master' of github.com:mongodb/mongo-python-driver into …

d9085b8

…PYTHON-2723

Ensure that neither ignoreResultAndError nor expectError interfere wi…

13d67c2

…th propagating exceptions from a callback operation to withTransaction

blink1073 requested a review from ShaneHarvey March 26, 2024 01:55

blink1073 marked this pull request as ready for review March 26, 2024 01:55

blink1073 closed this Mar 26, 2024

blink1073 reopened this Mar 26, 2024

ShaneHarvey requested changes Mar 26, 2024

View reviewed changes

blink1073 requested a review from ShaneHarvey March 26, 2024 19:07

handle mongos_clients

9dce940

fix mongos_client handling

2e72e17

ShaneHarvey approved these changes Mar 26, 2024

View reviewed changes

blink1073 merged commit e37394d into mongodb:master Mar 26, 2024
66 of 67 checks passed

blink1073 deleted the PYTHON-2723 branch March 26, 2024 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PYTHON-2723 Convert transactions spec tests to unified test format #1543

PYTHON-2723 Convert transactions spec tests to unified test format #1543

blink1073 commented Mar 6, 2024

ShaneHarvey left a comment

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024

ShaneHarvey Mar 26, 2024

blink1073 Mar 26, 2024

ShaneHarvey Mar 26, 2024

ShaneHarvey Mar 26, 2024

blink1073 Mar 26, 2024

ShaneHarvey Mar 26, 2024

blink1073 Mar 26, 2024

ShaneHarvey Mar 26, 2024

blink1073 Mar 26, 2024

ShaneHarvey Mar 26, 2024

blink1073 Mar 26, 2024

blink1073 commented Mar 26, 2024

ShaneHarvey commented Mar 26, 2024

ShaneHarvey commented Mar 26, 2024 •

edited

Loading

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024 •

edited

Loading

ShaneHarvey left a comment

	def kill_all_sessions(self):
	clients = self.mongos_clients if self.mongos_clients else [self.client]
	for client in clients:
	try:
	client.admin.command("killAllSessions", [])
	except OperationFailure:
	# "operation was interrupted" by killing the command's
	# own session.
	pass

PYTHON-2723 Convert transactions spec tests to unified test format #1543

PYTHON-2723 Convert transactions spec tests to unified test format #1543

Conversation

blink1073 commented Mar 6, 2024

ShaneHarvey left a comment

Choose a reason for hiding this comment

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blink1073 commented Mar 26, 2024

ShaneHarvey commented Mar 26, 2024

ShaneHarvey commented Mar 26, 2024 • edited Loading

blink1073 commented Mar 26, 2024

blink1073 commented Mar 26, 2024 • edited Loading

ShaneHarvey left a comment

Choose a reason for hiding this comment

ShaneHarvey commented Mar 26, 2024 •

edited

Loading

blink1073 commented Mar 26, 2024 •

edited

Loading