PYTHON-2859 Add BSON Binary subtype 7 #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Oct 25, 2021
bson/binary.py
Outdated
| @@ -23,6 +23,8 @@ | |||
|
|
|||
| This is the default subtype for binary data. | |||
| """ | |||
| COLUMN_SUBTYPE = 0x07 | |||
| """BSON binary subtype for columns""" | |||
There was a problem hiding this comment.
A few comments:
- The constants in this file are defined in increasing order. Please move this down below MD5_SUBTYPE.
- please use 7 instead of 0x07 since none of the other constants use hex.
- For the docstring, it should end in a period. Please also add a
versionadded. - Please check
doc/api/bson/binary.rstto see if we need to update the docs as well.
ShaneHarvey
requested changes
Oct 26, 2021
| @@ -169,6 +169,11 @@ class UuidRepresentation: | |||
| """BSON binary subtype for an MD5 hash. | |||
| """ | |||
|
|
|||
| COLUMN_SUBTYPE = 7 | |||
| """BSON binary subtype for columns. | |||
| .. versionadded:: 4.0 | |||
There was a problem hiding this comment.
Please check that the docs render correctly: https://pymongo--763.org.readthedocs.build/en/763/api/bson/binary.html
In this case there is a missing new line.
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the spec changes have already been added into pymongo. So all that is left is to add the constant.