Skip to content

Update trust-dns-* dependencies #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

nevi-me
Copy link
Contributor

@nevi-me nevi-me commented Jan 2, 2020

This has the side effect of replacing tokio=0.1 with 0.3, and reducing the number of dependencies being built.

I'm trying to reduce the number of dependencies on my projects as I'm moving them to async_await syntax. I noticed that trust-dns-resolver is still using tokio=0.1

This has the side effect of replacing tokio=0.1 with 0.3, and reducing the number of dependencies being built
@saghm saghm self-requested a review January 2, 2020 17:00
@saghm
Copy link
Contributor

saghm commented Jan 2, 2020

The failures are due to issues with our CI, not due to the driver, so I'll merge this now. Thanks for the contribution!

@saghm saghm merged commit 6d2f49e into mongodb:master Jan 2, 2020
@nevi-me nevi-me deleted the trust-dns-update branch January 2, 2020 21:26
@nevi-me
Copy link
Contributor Author

nevi-me commented Jan 2, 2020

Hey @saghm, I see that the RUST project on JIRA is now visible to the public, but I can't create a new JIRA.

I wanted to create a bug for FindOneOptions, it seems like the sort option is not included, but it's there for FindOneAnd*.

I've been using find() with a limit of 1 instead of find_one() for now, but this omission might confuse some people.

@saghm
Copy link
Contributor

saghm commented Jan 2, 2020

Hello! You're correct, we do need to add the sort field to FindOptions FindOneOptions. I'm actually having trouble filing a ticket for it now myself; I think that the settings may have gotten messed up when the JIRA was made public this morning. Once we get that sorted out, I'll comment here with the ticket number. Thanks!

@nevi-me
Copy link
Contributor Author

nevi-me commented Jan 2, 2020

Hello! You're correct, we do need to add the sort field to FindOptions. I'm actually having trouble filing a ticket for it now myself; I think that the settings may have gotten messed up when the JIRA was made public this morning. Once we get that sorted out, I'll comment here with the ticket number. Thanks!

I think it's just FindOneOptions as FindOptions has it already

@saghm
Copy link
Contributor

saghm commented Jan 2, 2020

Oops, sorry for the typo; I meant to say FindOneOptions

@saghm
Copy link
Contributor

saghm commented Jan 3, 2020

@nevi-me any chance you could try filing a JIRA ticket for this now? We just changed the permissions, and we want to make sure users are able to file tickets now

@nevi-me
Copy link
Contributor Author

nevi-me commented Jan 4, 2020

Here it is: https://jira.mongodb.org/browse/RUST-266

@saghm
Copy link
Contributor

saghm commented Jan 5, 2020

Awesome, thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants