RUST-2001 Allow SRV hostnames with less than three parts #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Oct 1, 2024
| if host_list.len() != 1 { | ||
| return Err(ErrorKind::InvalidArgument { | ||
| message: "exactly one host must be specified with 'mongodb+srv'".into(), | ||
| let host_info = if !srv { |
There was a problem hiding this comment.
This isn't directly related to the change, but when I was reading through to understand the original code I had a hard time skimming this section. This changes it to put the success cases up front and have the error cases nicely enumerated.
isabelatkinson
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2001
The actual changed logic is in
LookupHosts::validate(which used to be inSrvResolver::get_srv_hosts), and is the conditional bit near the top checking the length oforiginal_hostname_parts. The rest of this is refactoring to make the new logic testable.