Skip to content

Disallow setting query_type for encrypt_expression #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

isabelatkinson
Copy link
Contributor

Addresses the bug described in this comment

@isabelatkinson isabelatkinson changed the title Disallow setting query_type for encrypt_expression Disallow setting query_type for encrypt_expression Jan 3, 2025
@@ -15,6 +15,8 @@
//! .build();
//! ```

#[cfg(feature = "in-use-encryption")]
pub use crate::action::csfle::{DataKeyOptions, EncryptOptions};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were missing from the options module. They're currently importable from the action::csfle module, but that's inconsistent with our other option types, so I thought it was worth it to add them here as well.

@isabelatkinson isabelatkinson marked this pull request as ready for review January 6, 2025 18:13
@isabelatkinson isabelatkinson requested a review from abr-egn January 6, 2025 18:13
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@isabelatkinson isabelatkinson merged commit 509d27e into mongodb:main Jan 7, 2025
17 checks passed
@isabelatkinson isabelatkinson deleted the query-type-fix branch January 30, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants