RUST-666 Add options for timeseries collection creation #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Jun 29, 2021
|
|
||
| /// Duration indicating after how long old time-series data should be deleted. | ||
| #[serde( | ||
| default, |
There was a problem hiding this comment.
I don't know why this field needs to be explicitly marked as using the default when it's not present when others don't, but without this annotation some tests fail in deserialization complaining about missing field "expireAfterSeconds".
There was a problem hiding this comment.
I think it's because we provide special serialization / deserialization helpers for this field which override the default behavior.
patrickfreed
approved these changes
Jun 30, 2021
|
|
||
| /// Duration indicating after how long old time-series data should be deleted. | ||
| #[serde( | ||
| default, |
There was a problem hiding this comment.
I think it's because we provide special serialization / deserialization helpers for this field which override the default behavior.
src/db/options.rs
Outdated
| @@ -83,6 +85,17 @@ pub struct CreateCollectionOptions { | |||
|
|
|||
| /// The default configuration for indexes created on this collection, including the _id index. | |||
| pub index_option_defaults: Option<IndexOptionDefaults>, | |||
|
|
|||
| /// Specifies options for creating a timeseries collection. | |||
There was a problem hiding this comment.
Can we document here that this feature is only available on 5.0+?
isabelatkinson
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.