RUST-768 Pass versioned API parameters to getMore and transaction-continuing commands.
#397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
approved these changes
Jul 19, 2021
| @@ -12,6 +12,10 @@ use super::run_unified_format_test; | |||
| #[cfg_attr(feature = "async-std-runtime", async_std::test)] | |||
| async fn run() { | |||
| let _guard: RwLockWriteGuard<_> = LOCK.run_exclusively().await; | |||
| // TODO RUST-734 Unskip these tests on sharded deployments. | |||
| if TestClient::new().await.is_sharded() { | |||
There was a problem hiding this comment.
I think we ought to localize this skip to the tests in transaction-handling.json, as we'll lose test coverage for versioned API on sharded clusters otherwise. Unfortunately there's not a great way to do this; we could add a skip conditional on the test description in the unified runner for the affected tests, or alternatively transaction-handling.json could be moved temporarily to a separate directory and be given its own run function.
There was a problem hiding this comment.
Good call; I went with a third option and added some variants to run_spec_test to allow filtering on filename.
isabelatkinson
approved these changes
Jul 20, 2021
abr-egn
force-pushed
the
RUST-768/versioned-getMore
branch
from
d2e9028 to
c5d190e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.