Skip to content

RUST-736 Update driver documentation for 2.0 release #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

patrickfreed
Copy link
Contributor

@patrickfreed patrickfreed commented Aug 25, 2021

RUST-736

This PR updates the crate's documentation (found in lib.rs) to include the 2.0-friendly examples found in the readme. It also adds a table to both the readme and the crate documentation that lists and explains all of the feature flags. Finally, some more guidance was added to the Collection documentation about how to use its generic parameter.

To view the new changes locally, you can run cargo doc --no-deps --open.

@patrickfreed patrickfreed marked this pull request as ready for review August 25, 2021 23:34
//! your application, simply add it to your project's `Cargo.toml`.
//! ```toml
//! [dependencies]
//! mongodb = "2.0.0-beta.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "2.0.0" since we're doing this as part of the 2.0 release? (ditto other places with this version string)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to leave them as 2.0.0-beta.3 for now since that's the latest released version, and then update them right before the actual 2.0.0 release. This is usually what I've done for prior betas.

src/lib.rs Outdated
//! | `async-std-runtime` | Enable support for the `async-std` runtime | `async-std` 1.0 | no |
//! | `sync` | Expose the synchronous API (`mongodb::sync`). This flag cannot be used in conjunction with either of the async runtime feature flags. | `async-std` 1.0 | no |
//! | `aws-auth` | Enable support for the MONGODB-AWS authentication mechanism. | `reqwest` 0.11 | no |
//! | `bson-u2i` | Enable the `u2i` feature flag of the re-exported `bson` crate. | n/a | no |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go ahead with RUST-968 we should remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@patrickfreed patrickfreed merged commit 8c4fb66 into mongodb:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants