Skip to content

MONGOID-5078 add tests and documentation pertaining to atomic_selector usage in Mongoid #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2021
Merged

MONGOID-5078 add tests and documentation pertaining to atomic_selector usage in Mongoid #4985

merged 2 commits into from
Apr 28, 2021

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Apr 24, 2021 •
edited
Loading

No description provided.

@p-mongo p-mongo changed the title MONGOID-5078 5078 wip Fix MONGOID-5078 Background jobs queued during after_save, which atomically query sharded documents, fail because of atomic_selector. Apr 27, 2021
@p-mongo
Copy link
Contributor Author

p-mongo commented Apr 27, 2021

https://jira.mongodb.org/browse/MONGOID-5078

@p-mongo p-mongo changed the title Fix MONGOID-5078 Background jobs queued during after_save, which atomically query sharded documents, fail because of atomic_selector. MONGOID-5078 add tests and documentation pertaining to atomic_selector usage in Mongoid Apr 27, 2021
@p-mongo
Copy link
Contributor Author

p-mongo commented Apr 27, 2021

This PR marks shard_key_selector private on the basis of it not being documented in the tutorial. It is possible that it should be part of the public API - I think this will be resolved as part of MONGOID-5078 and when this is done, appropriate documentation should be added to the tutorial.

cc @dalton-braze

@p-mongo p-mongo requested review from alcaeus and comandeo April 27, 2021 22:06
@dalton-braze
Copy link
Contributor

The new documentation, tests, and naming clarification (shard_key_selector and shard_key_selector_in_db) look good!

@comandeo
Copy link
Contributor

👍

@p-mongo p-mongo merged commit 7ded888 into mongodb:master Apr 28, 2021
@dalton-braze dalton-braze mentioned this pull request Apr 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo comandeo approved these changes

@alcaeus alcaeus Awaiting requested review from alcaeus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-mongo @dalton-braze @comandeo @p