-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-4649): use SDAM handling for errors from min pool size population #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16f1586
refactor: give connection pool access to server
dariakp cfeeed1
feat: add original error message to PoolClearedError
dariakp 87ea6d4
refactor: separate sdam error handling from session error handling
dariakp ba32a46
refactor: make handleError a server class method
dariakp 02a5948
refactor: call sdam error handling on minPoolSize population
dariakp dbf45e4
test: fix cmap spec runner implementation
dariakp 74862b1
fix: emit connectionClosed event on establishment error
dariakp 3c3eadd
test: unskip implemented test
dariakp 0f8e6d8
test: skip incompatible pool clear test on lb
dariakp ac95f81
refactor: narrow ConnectionClosedEvent param type
dariakp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: emit connectionClosed event on establishment error
- Loading branch information
commit 74862b16de37bee6db9ea5c71cc3d03e45c54f81
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.