Skip to content

feat(NODE-4721): add aws-sdk as optional dependency #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 18, 2022
Merged

feat(NODE-4721): add aws-sdk as optional dependency #3446

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd0ba5a
feat(NODE-4721): add aws-sdk as optional dependency
durran Oct 13, 2022
ec41d08
test(NODE-4721): log creds on evg
durran Oct 13, 2022
afdb0b0
test(NODE-4721): use promise api
durran Oct 14, 2022
e1f19c9
test(NODE-4721): use sdk when available
durran Oct 14, 2022
39f26ee
test(NODE-4721): use internal aws error class
durran Oct 14, 2022
3825a32
test(NODE-4721): fix error name
durran Oct 14, 2022
c60586c
test(NODE-4721): check error message from sdk
durran Oct 14, 2022
c5e7a5b
test(NODE-4721): fix range check
durran Oct 14, 2022
890761b
fix: typo
durran Oct 15, 2022
4c404df
test(NODE-4721): install deps with and without options
durran Oct 17, 2022
7818a4f
tets(NODE-4721): fix ts checks
durran Oct 17, 2022
8f82ec6
fix(NODE-4721): fix ts when no-optional provided
durran Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(NODE-4721): fix error name
  • Loading branch information
@durran
durran committed Oct 14, 2022
commit 3825a3229e8cf630057d82c79281033e146766b9
2 changes: 1 addition & 1 deletion src/cmap/auth/mongodb_aws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ function makeTempCredentials(credentials: MongoCredentials, callback: Callback<M
.catch(error => {
/* eslint no-console: 0 */
console.log('AWS ERROR', error);
callback(new MongoAwsError(error.message));
callback(new MongoAWSError(error.message));
});
}
}
Expand Down