Skip to content

feat(NODE-4691): interrupt in-flight operations on heartbeat failure #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 28, 2022
Merged

feat(NODE-4691): interrupt in-flight operations on heartbeat failure #3457

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1b60b6c
unskip tests and update cmap runner to use interruptInUseConnections
baileympearson Oct 24, 2022
1e2cb07
add poolcleared network error
baileympearson Oct 24, 2022
c1d3285
refactor: make Pool.clear take options object
baileympearson Oct 24, 2022
70c847d
feat: kill in-flight operations when monitor fails
baileympearson Oct 24, 2022
1135d6c
chore: fix lint
baileympearson Oct 31, 2022
7c7c607
chore: fix unit tests
baileympearson Oct 31, 2022
ab16a2f
chore: add link to follow up ticket in TODO
baileympearson Oct 31, 2022
c7cda84
add todo toconnection pool
baileympearson Oct 31, 2022
97d72a7
refactor: make new error subclass PoolClearedError
baileympearson Oct 31, 2022
c987ade
address comments
baileympearson Nov 18, 2022
8d181c0
consolidate lb logic in pool clear
baileympearson Nov 22, 2022
02f954a
update comments for interruptInUseConnections
baileympearson Nov 22, 2022
2ae7ae5
attach retryable write error label in constructor for error
baileympearson Nov 22, 2022
4084018
use checkIn in favor of manually emitting events
baileympearson Nov 22, 2022
2b6de4e
Skip failing interrupt in use test on lb topologies
baileympearson Nov 22, 2022
41c3781
remove unnecssary check in checkIn
baileympearson Nov 22, 2022
809803c
add type annotation to function
baileympearson Nov 28, 2022
6fa8e9b
remove TODO comment in connection pool
baileympearson Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use checkIn in favor of manually emitting events
  • Loading branch information
@baileympearson
baileympearson committed Nov 28, 2022
commit 408401809b12f5c898c85ad11cbae68463e2953b
9 changes: 4 additions & 5 deletions src/cmap/connection_pool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
* @param connection - The connection to check in
*/
checkIn(connection: Connection): void {
if (!this[kCheckedOut].has(connection)) {
return;
}
const poolClosed = this.closed;
const stale = this.connectionIsStale(connection);
const willDestroy = !!(poolClosed || stale || connection.closed);
Expand Down Expand Up @@ -472,12 +475,8 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
private interruptInUseConnections(minGeneration: number) {
for (const connection of this[kCheckedOut]) {
if (connection.generation <= minGeneration) {
this[kCheckedOut].delete(connection);
this.checkIn(connection);
connection.onError(new PoolClearedOnNetworkError(this));
this.emit(
ConnectionPool.CONNECTION_CLOSED,
new ConnectionClosedEvent(this, connection, 'stale')
);
}
}

Expand Down