Skip to content

feat(NODE-4034)!: make internal bulk result private #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 18, 2023
Merged

feat(NODE-4034)!: make internal bulk result private #3515

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6625a45
feat(NODE-4034): make internal bulk result private
durran Jan 5, 2023
d592a0f
feat: add properties to bulk write result
durran Jan 5, 2023
8ea38e5
test: fix missing insertedIds in spec tests
durran Jan 5, 2023
80bdaa3
chore: update migration guide
durran Jan 11, 2023
cb834ea
chore: link drivers ticket
durran Jan 11, 2023
4971fee
fix: add suggestions
durran Jan 12, 2023
4b6bea5
test: fix test
durran Jan 12, 2023
1badb1b
test: fix tests
durran Jan 12, 2023
318ffcb
test: add insertedIds to csfle bulk results
durran Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: link drivers ticket
  • Loading branch information
@durran
durran committed Jan 17, 2023
commit cb834ea4264f91e54c30157c72478b8ec0801ad6
2 changes: 1 addition & 1 deletion test/tools/unified-spec-runner/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ operations.set('rewrapManyDataKey', async ({ entities, operation }) => {

const rewrapManyDataKeyResult = await clientEncryption.rewrapManyDataKey(filter, opts);
if (rewrapManyDataKeyResult.bulkWriteResult != null) {
// TODO: Create DRIVERS ticket.
// TODO: Can be removed with DRIVERS-2523
//
// The unified spec runner match function will assert that documents have no extra
// keys. For `rewrapManyDataKey` operations, our unifed tests will fail because
Expand Down