Skip to content

feat(NODE-4950)!: remove bson-ext import #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 20, 2023
Merged

feat(NODE-4950)!: remove bson-ext import #3523

merged 9 commits into from
Jan 20, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 13, 2023

Description

What is changing?

Removes bson-ext import

What is the motivation for this change?

BSON-EXT no longer works with JS BSON v5 types

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review January 17, 2023 18:17
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 19, 2023
@nbbeeken nbbeeken requested a review from durran January 19, 2023 15:22
durran
durran previously approved these changes Jan 19, 2023
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 19, 2023
@durran durran merged commit 1470115 into main Jan 20, 2023
@durran durran deleted the NODE-4950-rm-bson-ext branch January 20, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants