Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Closes #6299: Auto reject any media site permission when a system permission is not allowed first #6301

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

Amejia481
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

…n a system

permission is not allowed first
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #6301 into master will increase coverage by 0.03%.
The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6301      +/-   ##
============================================
+ Coverage     78.63%   78.67%   +0.03%     
- Complexity     4632     4636       +4     
============================================
  Files           609      609              
  Lines         22282    22294      +12     
  Branches       3252     3259       +7     
============================================
+ Hits          17522    17539      +17     
+ Misses         3424     3418       -6     
- Partials       1336     1337       +1
Impacted Files Coverage Δ Complexity Δ
.../feature/sitepermissions/SitePermissionsFeature.kt 85.77% <90.9%> (-0.01%) 81 <5> (+4)
...mponents/support/migration/TelemetryIdentifiers.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...components/support/sync/telemetry/SyncTelemetry.kt 91.08% <0%> (+1.08%) 34% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260d9b4...b020317. Read the comment docs.

Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rocketsroger rocketsroger self-assigned this Mar 20, 2020
@rocketsroger rocketsroger removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 20, 2020
@Amejia481
Copy link
Contributor Author

bors r=rocketsroger

@Amejia481 Amejia481 added the 🛬 needs landing PRs that are ready to land label Mar 23, 2020
@Amejia481
Copy link
Contributor Author

bors r=rocketsroger

@bors
Copy link

bors bot commented Mar 24, 2020

Build succeeded

  • complete-push

@bors bors bot merged commit a4b34ec into mozilla-mobile:master Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants