This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Expose remaining maven artifacts to TaskCluster #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaiTabara
approved these changes
Sep 20, 2018
There was a problem hiding this comment.
Ah, thanks for adding this! 👍 I munged them locally for my #803 but I think it's better to have them merged like this first for history. I'll rebase anyway.
JohanLorenzo
approved these changes
Sep 20, 2018
There was a problem hiding this comment.
Thank you very much for taking care of them! I'm sorry I missed them in #808
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=========================================
Coverage ? 78.88%
Complexity ? 1170
=========================================
Files ? 160
Lines ? 4328
Branches ? 640
=========================================
Hits ? 3414
Misses ? 611
Partials ? 303Continue to review full report at Codecov.
|
|
😆 Welcome aboard! |
csadilek
added a commit
to csadilek/android-components
that referenced
this pull request
Sep 21, 2018
csadilek
added a commit
to csadilek/android-components
that referenced
this pull request
Sep 21, 2018
csadilek
added a commit
to csadilek/android-components
that referenced
this pull request
Sep 21, 2018
csadilek
added a commit
to csadilek/android-components
that referenced
this pull request
Sep 21, 2018
csadilek
added a commit
that referenced
this pull request
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are the ones we initially forgot.
r? @JohanLorenzo @MihaiTabara