This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Fix errors in contrib.django.tasks #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,12 +54,12 @@ def update_in_index(sender, instance, **kw): | |||
| for id_list in chunked(ids, chunk_size): | |||
| documents = [] | |||
|
|
|||
| for obj in model.objects.filter(id__in=id_list): | |||
| for obj in model.objects.filter(pk__in=id_list): | |||
There was a problem hiding this comment.
In order to change this here, you have to change it everywhere else, too. Currently, ElasticUtils requires that you use id and won't work with non-id primary keys.
StandardError is deprecated in python 3.x. Exception should be used instead.
|
For the record, when you update a branch, github doesn't send any notifications, so no one knows unless you also add a comment stating you updated the branch. |
|
I think all the failures are because Travis is running the tests in a Django 1.7 environment and that's failing. I created issue #259 to cover that. I need to spend some more time double-checking this PR. |
|
Should be fixed with: #272 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.