Skip to content

Anca/Test stabilization - multiple tabs navigation #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

soncuteanca
Copy link
Collaborator

Relevant Links

Bugzilla: 1960042
TestRail: 134647

Description of Code / Doc Changes

  • It appears that assertion position checks would sometimes occur during animation states where tab location temporarily moved in unexpected directions before settling in their final positions. The test failed intermittent, but I managed to reproduce it only in headed mode implying timing, rendering issue. Therefore first I've added a custom wait for the scrolling animations to be complete before checking positions. A test diagnosis (by tracking tab positions over milliseconds) showed that when scrolling left, tab X-coordinates actually increase (not decrease), and when scrolling right, they decrease (not increase).

Workflow Checklist

  • [ x] Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Copy link
Collaborator

@sv-hyacoub sv-hyacoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ben-c-at-moz
Copy link
Collaborator

It's fine to merge this, but would you mind making note of the discrepancy between the TestRail TC and the automated test in our channel? I think it might be worthwhile to get Tracy's opinion on that particular matter.]

That said, since the previous test also had that discrepancy, feel free to merge.

@soncuteanca soncuteanca merged commit 78b33c3 into main Apr 16, 2025
6 checks passed
@soncuteanca soncuteanca deleted the as/test-stabilization-multiple-tabs branch April 16, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants