Skip to content

Philimon/live poc #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 1, 2025
Merged

Philimon/live poc #558

merged 23 commits into from
May 1, 2025

Conversation

philimon-reset
Copy link
Collaborator

@philimon-reset philimon-reset commented Apr 15, 2025

Relevant Links

Bugzilla:
- 1958490
- 1955305
- 1955308

Description of Code / Doc Changes

Proof of concept for live site testing with the l10n harness

Process Changes Required

Mark the relevant boxes:

  • Changes or creates a BOM/POM (name the object model): AddressFill and CreditFill
  • Changes L10n harness

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@philimon-reset philimon-reset marked this pull request as ready for review April 23, 2025 20:24
@philimon-reset philimon-reset self-assigned this Apr 23, 2025
Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the way through, I'll pick up on the page object stuff tomorrow

@ben-c-at-moz
Copy link
Collaborator

Finished my review without any additional comments, I think these are the only things we need to really resolve, then I'd love to see a demo when it's closer to done. Thanks!

@philimon-reset
Copy link
Collaborator Author

Finished my review without any additional comments, I think these are the only things we need to really resolve, then I'd love to see a demo when it's closer to done. Thanks!

Finished most of the reviews except one and adding the region specific changes we talked about. Also got the web server functionality running so we are good to have a demo in out meeting.

@ben-c-at-moz ben-c-at-moz self-requested a review April 30, 2025 15:51
Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny question, but it's not big enough to block landing. Good work!

@philimon-reset philimon-reset merged commit 9e7f76f into main May 1, 2025
6 checks passed
@philimon-reset philimon-reset deleted the philimon/live-poc branch May 3, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants