Skip to content

Hani/ Passwors manager first batch refactor #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Apr 30, 2025

Relevant Links

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1953258

Description of Code / Doc Changes

  • Add decorator
  • Add constructor
  • Add/edit comments
  • Separate assignment instead of chained calling
  • Instance Attributes
  • Variable assignment

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (browser_object_panel_ui and page_object_about_pages.py):
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

N/A

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sv-hyacoub sv-hyacoub merged commit 65b0a32 into main May 5, 2025
6 checks passed
@sv-hyacoub sv-hyacoub deleted the Hani/refactor_pass_manager_batch1 branch May 5, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants