Ensure container runs as a CI check #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
force-pushed
the
ensure-container-runs
branch
from
2ae4dd1 to
138db9d
Compare
grahamalama
force-pushed
the
ensure-container-runs
branch
from
138db9d to
3b50867
Compare
grahamalama
force-pushed
the
ensure-container-runs
branch
from
3b8d626 to
969b51b
Compare
leplatrem
approved these changes
Aug 2, 2022
bsieber-mozilla
approved these changes
Aug 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we copy the new
asgi.pyfile (introduced in #161) into the container, which fixes #178.It also adds a step in the build / publish workflow to spin up the container and check that it starts successfully.